Skip to content

Testing: resolve 404 page asset loading on nested routes#1073

Closed
Bhumikagarggg wants to merge 11 commits into
layer5io:masterfrom
Bhumikagarggg:fix/404-nested-route-assets
Closed

Testing: resolve 404 page asset loading on nested routes#1073
Bhumikagarggg wants to merge 11 commits into
layer5io:masterfrom
Bhumikagarggg:fix/404-nested-route-assets

Conversation

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates asset paths across various layout templates and partials to use absolute URLs, and removes the scripts partial from the 404 page. The review feedback points out a security regression in head-css.html due to the removal of Subresource Integrity (SRI) attributes, suggesting the use of .Permalink instead. Additionally, several comments recommend standardizing HTML formatting by using double quotes for attributes, removing leading slashes in asset paths, and cleaning up extra spaces within Hugo template tags.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread layouts/partials/head-css.html Outdated
Comment thread layouts/partials/favicon.html Outdated
Comment thread layouts/partials/favicon.html Outdated
Comment thread layouts/partials/navbar.html Outdated
Comment thread layouts/partials/navbar.html Outdated
Comment thread layouts/partials/navbar.html Outdated
Comment thread layouts/partials/navbar.html Outdated
Comment thread layouts/partials/navbar.html Outdated
Comment thread layouts/partials/navbar.html Outdated
Comment thread layouts/partials/navbar.html Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-06-04 10:53 UTC

Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
@Bhumikagarggg Bhumikagarggg marked this pull request as draft June 3, 2026 19:47
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
@Bhumikagarggg Bhumikagarggg changed the title fix: resolve 404 page asset loading on nested routes Testing: resolve 404 page asset loading on nested routes Jun 4, 2026
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant